(WIP) Arbitrary mode support, phase 1 #1872
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thommey
force-pushed
the
feature/arbchanmodes2
branch
2 times, most recently
from
005b4d7 to
c6e5a76
Compare
thommey
force-pushed
the
feature/arbchanmodes2
branch
4 times, most recently
from
0258744 to
acf0fcd
Compare
thommey
force-pushed
the
feature/arbchanmodes2
branch
from
acf0fcd to
772f123
Compare
thommey
force-pushed
the
feature/arbchanmodes2
branch
from
772f123 to
8303e27
Compare
| return result; | ||
| } | ||
|
|
||
| char *join_str_array(char **argv, int argc, char *delim) |
Member
There was a problem hiding this comment.
can we have last parameter type char or is there a need for delimiters longer than 1 char?
Member
There was a problem hiding this comment.
on the other hand, i can imagine things delimiters like ", ". but i think for generic misc functions exported via module API, we should make the output buffer a parameter and len, not a static array. could be useful for threaded code or for code that needs to join into a buffer longer than 512 chars.
Member
Author
There was a problem hiding this comment.
I think keeping it open for multi-char delimiters is more flexible and doesn't make it any more difficult to use.
Caller-provided buffer with length limitation makes sense, I'll change that.
| void splitcn(char *, char *, char, size_t); | ||
| void remove_crlf(char **); | ||
| parsed_irc_t parse_irc(char *); | ||
| char *join_str_array(char **argv, int argc, char *delim); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: various
Patch by: thommey
One-line summary: Understand mode info from raw 005 isupport and parse modes correctly
Additional description (if needed):
Phase 1 is parsing mode info from ISUPPORT raw 005 and using it to properly split modes (primarily for bind mode / pushmode).
It is not intended to overhaul eggdrop's mode enforcement or understanding of/reaction to modes.
The goal is to introduce proper parsing without breaking anything first.
Test cases demonstrating functionality (if applicable):
Basic parsing unit tests:
cd src/mod/irc.mod && make test(needs criterion)FULL FF-MERGE, NO SQUASHING
Commit history is clean, review individual commits instead of full diff