-
Notifications
You must be signed in to change notification settings - Fork 160
feat: responses api phase 2 #1791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b8eac7e to
fcbc267
Compare
fb00241 to
e1ec544
Compare
|
We should consider build the unified API based on the open responses https://www.openresponses.org/specification |
- Updated the handling of ResponseNewParamsInputUnion to use pointer utility from k8s.io/utils/ptr. - Modified tests in endpointspec_test.go and openai_responses_test.go to reflect changes in input handling. - Simplified response event processing in responses.go and openai_responses.go by removing unnecessary JSON unmarshalling. Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
…n buildResponsesResponseAttributes Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
9bcda7a to
375ba9a
Compare
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
3dc2548 to
34fa747
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
==========================================
- Coverage 84.36% 84.23% -0.13%
==========================================
Files 119 119
Lines 13282 15478 +2196
==========================================
+ Hits 11205 13038 +1833
- Misses 1416 1601 +185
- Partials 661 839 +178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It seems very similar. Can we address it in a separate PR ? |
Description
This PR is a follow up of initial support for OpenAI's Responses API PR and implements the following pending work.
Related PRs
Related PR: #1649