Skip to content

Conversation

@sivanantha321
Copy link
Contributor

@sivanantha321 sivanantha321 commented Jan 20, 2026

Description
This PR is a follow up of initial support for OpenAI's Responses API PR and implements the following pending work.

  • Replace OpenAI SDK Union types with our own
  • Improve and add more openinference traces req/res atrributes and configuration.

Related PRs
Related PR: #1649

@sivanantha321 sivanantha321 changed the title Responses api phase 2 feat: responses api phase 2 Jan 20, 2026
@sivanantha321 sivanantha321 force-pushed the responses-api-ph-2 branch 6 times, most recently from b8eac7e to fcbc267 Compare January 27, 2026 08:27
@yuzisun
Copy link
Contributor

yuzisun commented Jan 27, 2026

We should consider build the unified API based on the open responses https://www.openresponses.org/specification

- Updated the handling of ResponseNewParamsInputUnion to use pointer utility from k8s.io/utils/ptr.
- Modified tests in endpointspec_test.go and openai_responses_test.go to reflect changes in input handling.
- Simplified response event processing in responses.go and openai_responses.go by removing unnecessary JSON unmarshalling.

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
…n buildResponsesResponseAttributes

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 96.17347% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.23%. Comparing base (84ac8a8) to head (b087426).

Files with missing lines Patch % Lines
...rnal/tracing/openinference/openai/request_attrs.go 94.27% 11 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
- Coverage   84.36%   84.23%   -0.13%     
==========================================
  Files         119      119              
  Lines       13282    15478    +2196     
==========================================
+ Hits        11205    13038    +1833     
- Misses       1416     1601     +185     
- Partials      661      839     +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sivanantha321
Copy link
Contributor Author

sivanantha321 commented Jan 29, 2026

We should consider build the unified API based on the open responses https://www.openresponses.org/specification

It seems very similar. Can we address it in a separate PR ?

@sivanantha321 sivanantha321 marked this pull request as ready for review January 29, 2026 14:51
@sivanantha321 sivanantha321 requested a review from a team as a code owner January 29, 2026 14:51
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 29, 2026
@mathetake mathetake enabled auto-merge (squash) January 30, 2026 18:33
@mathetake mathetake merged commit d91aa16 into envoyproxy:main Jan 30, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants