-
Notifications
You must be signed in to change notification settings - Fork 5.2k
http: add sse parser utility in common #43081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeterL328
wants to merge
13
commits into
envoyproxy:main
Choose a base branch
from
PeterL328:yleng/common_sse_parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
Contributor
Author
|
cc: @botengyao |
Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
Member
botengyao
reviewed
Jan 21, 2026
Member
botengyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and test!
/wait
Signed-off-by: Peter Leng <yleng@pinterest.com>
tyxia
reviewed
Jan 23, 2026
Member
tyxia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for your contribution @PeterL328 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add sse parser utility for http common
Additional Description: This PR adds a Server-Sent Events (SSE) parser utility to source/common/http/sse/. The parser handles SSE event stream parsing according to the SSE specification, supporting event fields (event, data, id, retry), comment handling, and various line ending formats (LF, CR, CRLF). This is a foundational utility that will be used by upcoming HTTP filters for processing SSE streams.
SSE parser logic moved from #42762 so diff can be smaller for review
Risk Level: Low
Testing: Unit + Fuzzer
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A