Skip to content

Conversation

@PeterL328
Copy link
Contributor

@PeterL328 PeterL328 commented Jan 20, 2026

Commit Message: Add sse parser utility for http common
Additional Description: This PR adds a Server-Sent Events (SSE) parser utility to source/common/http/sse/. The parser handles SSE event stream parsing according to the SSE specification, supporting event fields (event, data, id, retry), comment handling, and various line ending formats (LF, CR, CRLF). This is a foundational utility that will be used by upcoming HTTP filters for processing SSE streams.

SSE parser logic moved from #42762 so diff can be smaller for review
Risk Level: Low
Testing: Unit + Fuzzer
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
@PeterL328
Copy link
Contributor Author

cc: @botengyao

Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
@botengyao
Copy link
Member

cc @tyxia @abeyad as well

Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and test!

/wait

Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
@tyxia tyxia self-assigned this Jan 22, 2026
Copy link
Member

@tyxia tyxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for your contribution @PeterL328 !

Signed-off-by: Peter Leng <yleng@pinterest.com>
@PeterL328 PeterL328 requested a review from tyxia January 24, 2026 00:39
Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
Signed-off-by: Peter Leng <yleng@pinterest.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants