Skip to content

Conversation

@Aias00
Copy link
Contributor

@Aias00 Aias00 commented Jan 22, 2026

What type of PR is this?

increase global shared rate limit in test data to 100, update the E2E test for shared rate limits without client selectors
fix this: https://github.com/envoyproxy/gateway/actions/runs/21241339852/job/61121125255

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

…he E2E test for shared rate limits without client selectors

Signed-off-by: liuhy <liuhongyu@apache.org>
@Aias00 Aias00 requested a review from a team as a code owner January 22, 2026 11:06
Copilot AI review requested due to automatic review settings January 22, 2026 11:06
@netlify
Copy link

netlify bot commented Jan 22, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit e567582
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6974c9f9036ea70008159dfd
😎 Deploy Preview https://deploy-preview-8025--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the global shared rate limit test data and strengthens the E2E test that verifies gateway-level shared rate limits without client selectors, to reduce flakiness and align with the new 100-requests-per-hour limit.

Changes:

  • Increase the gateway-level global shared rate limit (without clientSelectors) from 21 to 100 requests per hour in the test manifest.
  • Rewrite the shared_no_client_selectors subtest in RateLimitGlobalMergeTest to:
    • Assert the X-Ratelimit-Limit header reports 100, 100;w=3600.
    • Warm up the route until a 200 is observed, then send 99 additional successful requests and verify that the 101st request is rate-limited with HTTP 429.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/e2e/tests/ratelimit.go Refines the shared_no_client_selectors E2E subtest to explicitly validate the new 100-requests-per-hour shared limit, including header checking and precise counting of allowed vs. limited requests.
test/e2e/testdata/ratelimit-global-shared-and-unshared-header-match.yaml Updates the gateway-level global shared rate limit rule (no clientSelectors) from 21 to 100 requests per hour to match the revised test logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.65%. Comparing base (a8ddb0d) to head (c674821).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8025      +/-   ##
==========================================
- Coverage   73.70%   73.65%   -0.05%     
==========================================
  Files         237      237              
  Lines       35653    35653              
==========================================
- Hits        26278    26261      -17     
- Misses       7515     7529      +14     
- Partials     1860     1863       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zirain zirain changed the title feat: update the E2E test for shared rate limits without client selectors e2e: update the test for shared rate limits without client selectors Jan 23, 2026
@zirain
Copy link
Member

zirain commented Jan 24, 2026

all the e2e failed, is there some problem with your changes?

@Aias00
Copy link
Contributor Author

Aias00 commented Jan 24, 2026

all the e2e failed, is there some problem with your changes?

i will check this later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants