-
Notifications
You must be signed in to change notification settings - Fork 650
e2e: update the test for shared rate limits without client selectors #8025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…he E2E test for shared rate limits without client selectors Signed-off-by: liuhy <liuhongyu@apache.org>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the global shared rate limit test data and strengthens the E2E test that verifies gateway-level shared rate limits without client selectors, to reduce flakiness and align with the new 100-requests-per-hour limit.
Changes:
- Increase the gateway-level global shared rate limit (without clientSelectors) from 21 to 100 requests per hour in the test manifest.
- Rewrite the
shared_no_client_selectorssubtest inRateLimitGlobalMergeTestto:- Assert the
X-Ratelimit-Limitheader reports100, 100;w=3600. - Warm up the route until a 200 is observed, then send 99 additional successful requests and verify that the 101st request is rate-limited with HTTP 429.
- Assert the
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/e2e/tests/ratelimit.go |
Refines the shared_no_client_selectors E2E subtest to explicitly validate the new 100-requests-per-hour shared limit, including header checking and precise counting of allowed vs. limited requests. |
test/e2e/testdata/ratelimit-global-shared-and-unshared-header-match.yaml |
Updates the gateway-level global shared rate limit rule (no clientSelectors) from 21 to 100 requests per hour to match the revised test logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8025 +/- ##
==========================================
- Coverage 73.70% 73.65% -0.05%
==========================================
Files 237 237
Lines 35653 35653
==========================================
- Hits 26278 26261 -17
- Misses 7515 7529 +14
- Partials 1860 1863 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
all the e2e failed, is there some problem with your changes? |
i will check this later |
What type of PR is this?
increase global shared rate limit in test data to 100, update the E2E test for shared rate limits without client selectors
fix this: https://github.com/envoyproxy/gateway/actions/runs/21241339852/job/61121125255
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes/No