fix: race in gatewaapi runner #8037
Open
+276
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
changed the title
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8037 +/- ##
==========================================
+ Coverage 73.65% 73.70% +0.05%
==========================================
Files 237 237
Lines 35653 35662 +9
==========================================
+ Hits 26259 26284 +25
+ Misses 7530 7517 -13
+ Partials 1864 1861 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Jan 24, 2026
| r.Logger = r.Logger.WithName(r.Name()).WithValues("runner", r.Name()) | ||
|
|
||
| go r.startWasmCache(ctx) | ||
| r.done.Add(2) |
Contributor
There was a problem hiding this comment.
can you add a comment here, outlining why 2 is needed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #8035