Skip to content

Conversation

@Aditya7880900936
Copy link
Contributor

What this PR does

Envoy Gateway previously served only the leaf certificate from tls.crt
and ignored ca.crt when building the served TLS certificate chain.

This PR:

  • Extends the IR to carry optional CA certificates
  • Appends ca.crt to the served certificate chain when present
  • Keeps TLS validation behavior unchanged

Why this is needed

Incomplete certificate chains can cause client-side verification
and OCSP-related issues. This change aligns Envoy Gateway behavior
with common TLS expectations and cert-manager style secrets.

Backward compatibility

  • No behavior change if tls.crt already contains the full chain
  • No change to certificate validation or mTLS logic

Fixes #7804

Signed-off-by: Aditya7880900936 <adityasanskarsrivastav788@gmail.com>
@Aditya7880900936 Aditya7880900936 requested a review from a team as a code owner January 24, 2026 16:52
@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cerulean-figolla-1f9435 ready!

Name Link
🔨 Latest commit 4ab0991
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6974f8e9ade0df00089dd3dc
😎 Deploy Preview https://deploy-preview-8038--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.66%. Comparing base (d88b5b5) to head (4ab0991).

Files with missing lines Patch % Lines
internal/xds/translator/listener.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8038      +/-   ##
==========================================
+ Coverage   73.65%   73.66%   +0.01%     
==========================================
  Files         237      237              
  Lines       35653    35662       +9     
==========================================
+ Hits        26259    26271      +12     
+ Misses       7530     7527       -3     
  Partials     1864     1864              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add ca.crt into served up cert

1 participant