fix: handle Bank Leumi login modal (fixes #969) #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add modal detection and dismissal for button ID f3ac5286-8b3d-1bff-cca8-105a2e34e114 - Wait 2 seconds for modal to appear before attempting to click - Add comprehensive error handling and debug logging - Fixes issue where scraper would get stuck on login modal - Resolves eshaham#969
| await new Promise(resolve => setTimeout(resolve, 2000)); | ||
|
|
||
| // Try to find and click the modal button | ||
| const modalButton = await page.waitForSelector('#f3ac5286-8b3d-1bff-cca8-105a2e34e114', { timeout: 5000 }); |
Collaborator
There was a problem hiding this comment.
We already have waitUntilElementFound and clickButton in helpers\elements-interactions.ts. can you see if they work for your case?
| // Handle the new modal that appears after login | ||
| debug('Checking for login modal...'); | ||
|
|
||
| try { |
Collaborator
There was a problem hiding this comment.
Considre adding the logic as waitForModalToClose (or any other name) then here await waitForModalToClose()
Co-authored-by: Daniel Hauser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Issue
Fixes #969 - Bank Leumi modal on login that prevents scraper from proceeding
📝 Description
Bank Leumi introduced a new modal that appears after login with button ID
f3ac5286-8b3d-1bff-cca8-105a2e34e114. This modal blocks the scraper from proceeding to account selection, causing timeouts and failures.🔧 Changes Made
waitForPostLoginfunction✅ Testing
🎯 Benefits