Fix hardcoded notch marginTop in RNTester #55132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
sbuggay
force-pushed
the
export-D90514023
branch
from
aaa581f to
852ab3c
Compare
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jan 13, 2026
Summary: RNTester doesnt use safe areas and instead hardcodes the margin top based on Platform.OS. Issue is that AppleTV returns `ios` so there is a gap since there is no notch. Instead of adding a new Metro platform, just using the deviceIdiom instead for now. Changelog: [internal] Differential Revision: D90514023
sbuggay
force-pushed
the
export-D90514023
branch
from
852ab3c to
d6cafaf
Compare
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jan 13, 2026
Summary: RNTester doesnt use safe areas and instead hardcodes the margin top based on Platform.OS. Issue is that AppleTV returns `ios` so there is a gap since there is no notch. Instead of adding a new Metro platform, just using the deviceIdiom instead for now. Changelog: [internal] Reviewed By: Abbondanzo Differential Revision: D90514023
Summary: `multipleTouchEnabled` is not available for UIViews for AppleTV, compiling them out. Changelog: [internal] Reviewed By: Abbondanzo Differential Revision: D90513833
Summary: UIOrientation usage is unsupported on AppleTV, compiling out. Changelog: [internal] Reviewed By: Abbondanzo Differential Revision: D90513975
…55129) Summary: TextInput uses a lot of UIKit APIs that are unavailable on AppleTV, compiling them out. Changelog: [internal] Reviewed By: shwanton Differential Revision: D90514227
Summary: Compile out unsupported UIKit APIs used by RCTView and it's manager. Changelog: [internal] Reviewed By: Abbondanzo Differential Revision: D90513795
Summary: [UIColor systemBackgroundColor] is unavailable on AppleTV, defaulting to [UIColor clearColor]. Changelog: [internal] Reviewed By: Abbondanzo Differential Revision: D90514013
Summary: RNTester doesnt use safe areas and instead hardcodes the margin top based on Platform.OS. Issue is that AppleTV returns `ios` so there is a gap since there is no notch. Instead of adding a new Metro platform, just using the deviceIdiom instead for now. Changelog: [internal] Reviewed By: Abbondanzo Differential Revision: D90514023
sbuggay
force-pushed
the
export-D90514023
branch
from
d6cafaf to
5466b69
Compare
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Jan 13, 2026
Summary: RNTester doesnt use safe areas and instead hardcodes the margin top based on Platform.OS. Issue is that AppleTV returns `ios` so there is a gap since there is no notch. Instead of adding a new Metro platform, just using the deviceIdiom instead for now. Changelog: [internal] Reviewed By: Abbondanzo Differential Revision: D90514023
|
This pull request has been merged in 400a3b5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RNTester doesnt use safe areas and instead hardcodes the margin top based on Platform.OS. Issue is that AppleTV returns
iosso there is a gap since there is no notch. Instead of adding a new Metro platform, just using the deviceIdiom instead for now.Changelog: [internal]
Differential Revision: D90514023