Extend reading glb weights to handle unsigned byte and short component types#932
Closed
Extend reading glb weights to handle unsigned byte and short component types#932
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
…t types (#932) Summary: From the spec: > WEIGHTS_n: float, or normalized unsigned byte, or normalized unsigned short This extends support for weight types output in common tools. Reviewed By: jeongseok-meta Differential Revision: D90891854
facebook-github-bot
force-pushed
the
export-D90891854
branch
from
3e269b3 to
87ae04a
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…t types (#932) Summary: From the spec: > WEIGHTS_n: float, or normalized unsigned byte, or normalized unsigned short This extends support for weight types output in common tools. Reviewed By: jeongseok-meta Differential Revision: D90891854
facebook-github-bot
force-pushed
the
export-D90891854
branch
from
87ae04a to
22863ef
Compare
…t types (#932) Summary: From the spec: > WEIGHTS_n: float, or normalized unsigned byte, or normalized unsigned short This extends support for weight types output in common tools. Reviewed By: jeongseok-meta Differential Revision: D90891854
facebook-github-bot
force-pushed
the
export-D90891854
branch
from
22863ef to
01a488e
Compare
Contributor
|
This pull request has been merged in 2c72495. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
From the spec:
This extends support for weight types output in common tools.
Differential Revision: D90891854