Skip to content

Conversation

@CarterLi
Copy link
Member

Checklist

  • I have tested my changes locally.

Copilot AI review requested due to automatic review settings January 14, 2026 05:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares the v2.57.1 release with bug fixes, performance improvements, and logo updates. It includes Windows performance optimizations through refactored time handling and consolidated utility code, improved macOS SDK compatibility by replacing deprecated IOKit constants, simplified display server code by merging duplicate structures in X11/XCB implementations, and adds a new small variant of the PrismLinux logo.

Changes:

  • Version bumped from 2.57.0 to 2.57.1 in CMakeLists.txt
  • Added CHANGELOG entries documenting bug fixes for Linux compilation and macOS SDK compatibility
  • Consolidated Windows utility code (on_scope_exit template) into a shared header
  • Replaced deprecated kIOMainPortDefault with MACH_PORT_NULL for older macOS SDK support
  • Refactored X11/XCB display server code to merge property data structures
  • Optimized Windows time functions with precomputed QPC multiplier
  • Enhanced hostname retrieval reliability on Windows
  • Added PrismLinux small logo variant

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
CMakeLists.txt Version bump to 2.57.1
CHANGELOG.md Added release notes for v2.57.1 and formatting fixes for v2.57.0
debian/changelog.tpl Added changelog entry (version mismatch issue)
src/logo/ascii/prismlinux.txt Updated PrismLinux ASCII logo
src/logo/ascii/prismlinux_small.txt New small variant of PrismLinux logo
src/logo/builtin.c Registered PrismLinux_small logo
src/modules/logo/logo.c Removed redundant includes
src/common/windows/util.hpp New shared header for on_scope_exit utility template
src/detection/wm/wm_windows.cpp Uses shared on_scope_exit from util.hpp
src/detection/gpu/gpu_wsl.cpp Uses shared on_scope_exit from util.hpp
src/detection/camera/camera_windows.cpp Uses shared on_scope_exit from util.hpp
src/detection/bluetooth/bluetooth_windows.cpp Uses shared on_scope_exit from util.hpp
src/detection/physicalmemory/physicalmemory_apple.m Replaced deprecated kIOMainPortDefault with MACH_PORT_NULL
src/detection/bootmgr/bootmgr_apple.c Replaced deprecated kIOMainPortDefault with MACH_PORT_NULL
src/detection/displayserver/linux/xlib.c Merged property data structures (semicolon issue found)
src/detection/displayserver/linux/xcb.c Merged property data structures
src/common/time.h Optimized time functions and changed ffTimeSleep to return bool
src/common/impl/time.c Added precomputed QPC multiplier for Windows
src/common/impl/FFPlatform_windows.c Improved hostname retrieval with fallback and proper length handling
src/common/windows/nt.h Fixed indentation for NtQueryDirectoryFile parameters
.github/pull_request_template.md Added PR template with logo request requirements
.github/ISSUE_TEMPLATE/logo_request.yml Updated logo request template with improved wording

@CarterLi CarterLi merged commit 0418e9c into master Jan 14, 2026
39 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants