[4.x] Fixed ColumnTests Assertions with Custom Data Table #19092
+194
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The assertion methods listed below allow passing either an Eloquent Record or the the row index as the
$recordparameter.The functionality works - but the phpunit messages use
$record->getKey()which mean the assertions fail when used with an index instead of an Eloquent Record causing an error.assertTableColumnStateSetassertTableColumnStateNotSetassertTableColumnFormattedStateSetassertTableColumnFormattedStateNotSetassertTableColumnHasExtraAttributesassertTableColumnDoesNotHaveExtraAttributesassertTableColumnHasDescriptionassertTableColumnDoesNotHaveDescriptionassertTableSelectColumnHasOptionsassertTableSelectColumnDoesNotHaveOptionsVisual changes
None
Functional changes
assertTableRecordKeyExiststo give a friendly error if an invalid index is passed$recordas the$keyif it is not an Eloquent ModelCustomDataTablefixture (based on the existing `PostsTable)Workaround
In case anyone else needs a workaround before this is merged:
Add this to your TestCase:
And use it like this: