-
Notifications
You must be signed in to change notification settings - Fork 133
Add new IsInitialized and SetDebugMode support to the desktop analytics sdk. #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add in the new analytics dll and the new functions
Summary of ChangesHello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the desktop analytics SDK by introducing new APIs for checking initialization status and controlling debug mode. It ensures these desktop-specific features are gracefully handled on other platforms with NO-OP implementations. Additionally, the PR refines app lifecycle state tracking and logging level definitions, improving the overall robustness and clarity of the analytics SDK. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds IsInitialized and SetDebugMode support to the desktop analytics SDK. The changes include adding the new functions to the public C++ and C APIs, implementing them for the desktop platform, and providing no-op stubs for Android and iOS. New integration tests are also added to verify the functionality on desktop.
My review has identified a couple of points. First, the stub implementation for IsDesktopInitialized seems to have incorrect logic for when the analytics DLL is not loaded. Second, there are breaking changes to the public C API enums that are not mentioned in the PR description. These changes, while good practice, should be acknowledged as they affect API compatibility.
5745be1 to
d28fde9
Compare
The test should run on all platforms to make sure they don't fail. The sub for initialize analytics should default to returning false. If it really not load in that case.
d28fde9 to
2570190
Compare
✅ Integration test succeeded!Requested by @AustinBenoit on commit c47bb93 |
| bool IsDesktopInitialized() { return false; } | ||
|
|
||
| // NO-OP in Android and iOS. Only used in Windows. | ||
| void SetDesktopDebugMode(bool enabled) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to remove the "enabled" part, just so anything that warns about unused parameters doesn't complain. Also in the other stub implementations
Description
Add new IsInitialized and SetDebugMode support to the desktop analytics sdk.
Testing
Added new integration tests.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.