Skip to content

Conversation

@AustinBenoit
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Add new IsInitialized and SetDebugMode support to the desktop analytics sdk.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Added new integration tests.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@AustinBenoit AustinBenoit added the skip-release-notes Skip release notes check label Jan 13, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AustinBenoit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the desktop analytics SDK by introducing new APIs for checking initialization status and controlling debug mode. It ensures these desktop-specific features are gracefully handled on other platforms with NO-OP implementations. Additionally, the PR refines app lifecycle state tracking and logging level definitions, improving the overall robustness and clarity of the analytics SDK.

Highlights

  • Desktop Analytics API Extension: Introduced IsDesktopInitialized() to check the SDK's initialization status and SetDesktopDebugMode(bool enabled) to control debug logging, specifically for desktop platforms.
  • Cross-Platform Compatibility: Provided NO-OP implementations for IsDesktopInitialized() and SetDesktopDebugMode() on Android and iOS to maintain API consistency across platforms.
  • Enhanced App Lifecycle Tracking: Expanded the AppLifecycleState enum to include kFocused and kUnfocused states, allowing for more granular tracking of application focus.
  • Integration Test Coverage: Added new integration tests (TestDesktopInitialization, TestDesktopDebugMode) to validate the functionality of the newly introduced desktop analytics features.
  • Header and Enum Refinements: Updated header file naming conventions from _PUBLIC_ to _PRERELEASE_ and standardized GoogleAnalytics_LogLevel enum values with explicit assignments and documentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds IsInitialized and SetDebugMode support to the desktop analytics SDK. The changes include adding the new functions to the public C++ and C APIs, implementing them for the desktop platform, and providing no-op stubs for Android and iOS. New integration tests are also added to verify the functionality on desktop.

My review has identified a couple of points. First, the stub implementation for IsDesktopInitialized seems to have incorrect logic for when the analytics DLL is not loaded. Second, there are breaking changes to the public C API enums that are not mentioned in the PR description. These changes, while good practice, should be acknowledged as they affect API compatibility.

@AustinBenoit AustinBenoit force-pushed the feat/windows-initalized branch from 5745be1 to d28fde9 Compare January 13, 2026 17:11
The test should run on all platforms to make sure they don't fail.
The sub for initialize analytics should default to returning false.
If it really not load in that case.
@AustinBenoit AustinBenoit force-pushed the feat/windows-initalized branch from d28fde9 to 2570190 Compare January 13, 2026 17:20
@AustinBenoit AustinBenoit added the tests-requested: quick Trigger a quick set of integration tests. label Jan 13, 2026
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 13, 2026
@github-actions
Copy link

github-actions bot commented Jan 13, 2026

✅  Integration test succeeded!

Requested by @AustinBenoit on commit c47bb93
Last updated: Tue Jan 13 12:37 PST 2026
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 13, 2026
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 13, 2026
bool IsDesktopInitialized() { return false; }

// NO-OP in Android and iOS. Only used in Windows.
void SetDesktopDebugMode(bool enabled) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to remove the "enabled" part, just so anything that warns about unused parameters doesn't complain. Also in the other stub implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants