-
Notifications
You must be signed in to change notification settings - Fork 635
Elisa/fix(py)/extra flow genai hello #4124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @MengqinShen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive set of enhancements to the Google Generative AI plugin, expanding its capabilities to support a wider range of advanced model features. It includes critical updates to tool response processing, flexible API version management, and new configuration options for Gemini models. The accompanying sample applications have been thoroughly updated and extended to provide clear demonstrations of these new functionalities, including a dedicated example for Vertex AI, ensuring developers can easily leverage the latest generative AI advancements. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several enhancements and fixes, primarily focused on expanding the capabilities of the Google GenAI plugin. Key changes include support for per-request API versions, handling of multimodal tool responses, and adding new configuration options like thinking_config. The sample applications have been updated extensively to demonstrate these new features.
My review has identified a critical issue with unreachable code in one of the new sample flows, a medium-severity maintainability concern regarding the use of private library members, and a suggestion to improve code readability. Please see the detailed comments below.
This PR is to add extra flows in google-genai sample to match that in JS SDK.