Skip to content

Conversation

@romainguerrero
Copy link
Contributor

This pull request fix an issue with the Symfony Console 8.0 : it allow to determine which add or addCommand method for Application class should be called depending on the Symfony Console version.
The if (method_exists... test is added to keep the compatibility with previous Symfony Console versions.

Fixes #352.

…hould be called depending on the Symfony Console version
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.20%. Comparing base (2d8bde1) to head (3150940).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/Console/Application.php 85.71% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #353      +/-   ##
============================================
+ Coverage     79.83%   80.20%   +0.37%     
- Complexity      749      751       +2     
============================================
  Files            55       55              
  Lines          2603     2597       -6     
============================================
+ Hits           2078     2083       +5     
+ Misses          525      514      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ciloe
Copy link
Collaborator

Ciloe commented Jan 22, 2026

Many thanks, can you check the CS ?

@romainguerrero romainguerrero force-pushed the fix/console-8.0-removed-add-method branch from c6baa2d to 9f06c44 Compare January 22, 2026 10:22
@romainguerrero romainguerrero force-pushed the fix/console-8.0-removed-add-method branch from 9f06c44 to fc67c0c Compare January 22, 2026 10:31
@romainguerrero
Copy link
Contributor Author

Many thanks, can you check the CS ?

@Ciloe It should be OK with the new commits 👍

FYI I also updated the phpstan-baseline.neon with an updated ignored error message from Symfony

@Ciloe
Copy link
Collaborator

Ciloe commented Jan 22, 2026

Maybe you can launch CS and PHPstan in local before pushing ?

@romainguerrero romainguerrero force-pushed the fix/console-8.0-removed-add-method branch from f7180a6 to 3150940 Compare January 23, 2026 11:25
@romainguerrero
Copy link
Contributor Author

Maybe you can launch CS and PHPstan in local before pushing ?

Sorry @Ciloe, I lunched them but I had a memory limit issue with CS and the PHPstan was OK with my PHP 8.4 version but I saw you lunch them with the 8.0 version in the CI.

I updated the code and the phpunit test file to make it OK with both versions. I have now locally :

@Ciloe
Copy link
Collaborator

Ciloe commented Jan 23, 2026

Good job ! Many thanks

@Ciloe Ciloe merged commit cebf24a into friendsoftwig:main Jan 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatibility of v6.6 with Symfony Console 8.0

3 participants