-
Notifications
You must be signed in to change notification settings - Fork 35
Fix FatalError "undefined method Symfony\Component\Console\Application::add()" with the 8.0 Symfony Console version #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FatalError "undefined method Symfony\Component\Console\Application::add()" with the 8.0 Symfony Console version #353
Conversation
…hould be called depending on the Symfony Console version
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
============================================
+ Coverage 79.83% 80.20% +0.37%
- Complexity 749 751 +2
============================================
Files 55 55
Lines 2603 2597 -6
============================================
+ Hits 2078 2083 +5
+ Misses 525 514 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Many thanks, can you check the CS ? |
c6baa2d to
9f06c44
Compare
9f06c44 to
fc67c0c
Compare
@Ciloe It should be OK with the new commits 👍 FYI I also updated the |
|
Maybe you can launch CS and PHPstan in local before pushing ? |
f7180a6 to
3150940
Compare
Sorry @Ciloe, I lunched them but I had a memory limit issue with CS and the PHPstan was OK with my PHP 8.4 version but I saw you lunch them with the 8.0 version in the CI. I updated the code and the phpunit test file to make it OK with both versions. I have now locally :
|
|
Good job ! Many thanks |
This pull request fix an issue with the Symfony Console 8.0 : it allow to determine which
addoraddCommandmethod forApplicationclass should be called depending on the Symfony Console version.The
if (method_exists...test is added to keep the compatibility with previous Symfony Console versions.Fixes #352.