fix: player can now MoveUp #148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivace
requested changes
Jan 14, 2026
Member
avivace
left a comment
avivace
left a comment
There was a problem hiding this comment.
@mrcook Unfortunately we need to keep the PR tidy and not have other unrelated changes. Could you maybe try using a different editor or check the settings of your current one ? Or maybe just try to use GitHub UI to create the PR (try to edit the file in question and it'll create a copy/make you commit changes to your fork which then you can PR from).
Contributor
|
Good catch @mrcook! I checked the changes on my end and the fix works. |
ISSOtm
force-pushed
the
fix-player-movement
branch
from
d02a2b7 to
5356b1e
Compare
Member
|
Since it's a minor fix, I've just split the two actions in separate commits, so this PR can be rebase-merged while keeping focused commits. (Alternatively, the latter commit can simply be dropped if we'd rather not make that change at all.) |
avivace
added a commit
that referenced
this pull request
Jan 15, 2026
Supersedes #148 Co-authored-by: Michael R. Cook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #147
Note: my editor automatically removes the spaces from line ends so a few unrelated lines were touched.