Introduce local labels in hello-world.asm #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153
This seems to me like a reasonable balance of introducing a not-too-complex concept at a not-too-late time.
Earlier on in this "Memory" section, there's a lot of complexity that I'd consider to be more premature and less useful than local labels. (For example, even noting the existence of "SRAM", "OAM", "HRAM", etc in the memory map; or talking about "the chip selector" and how "it’s crucial to keep in mind that different addresses may be backed by different memory chips" -- I'm not saying those are bad things to know, but they certainly aren't applicable this early, whereas local labels would be very applicable to alleviate those long wordy labels I listed in the issue.)
I am not updating the larger projects in parts II and III to use local labels, but with this PR, they'd at least be an option for anyone maintaining that code.