ref: convert AutoBreadcrumbTrackingIntegration to Swift #7158
+534
−681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert SentryAutoBreadcrumbTrackingIntegration from Objective-C to Swift following the SwiftIntegration protocol pattern. Updated the conversion guide with learnings including: - Exposing Objective-C headers via SentryPrivate.h - Runtime initialization pattern for conditionally compiled classes - Typealias dependency injection pattern - Test fixture setup with dependency injection
Member
Author
|
@sentry review |
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
❌ 7 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…yAutoBreadcrumbTrackingIntegration This update adds the @objc annotation to the addBreadcrumb method, allowing it to be accessible from Objective-C code. Additionally, the import statement in the test file has been adjusted for consistency with Swift's SPI usage.
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1357911 | 1222.84 ms | 1258.38 ms | 35.54 ms |
| 37bc095 | 1210.00 ms | 1242.69 ms | 32.69 ms |
| 50e7b3e | 1221.54 ms | 1250.81 ms | 29.27 ms |
| 2b4e787 | 1226.06 ms | 1258.65 ms | 32.59 ms |
| e1e5f3b | 1220.60 ms | 1241.63 ms | 21.04 ms |
| 79e2bb8 | 1216.37 ms | 1242.42 ms | 26.05 ms |
| 013fd4d | 1216.02 ms | 1242.16 ms | 26.14 ms |
| 3b01aaf | 1194.98 ms | 1210.36 ms | 15.38 ms |
| 2c4362a | 1231.50 ms | 1255.95 ms | 24.45 ms |
| 5d67f5d | 1225.33 ms | 1262.76 ms | 37.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1357911 | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| 37bc095 | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 50e7b3e | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 2b4e787 | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| e1e5f3b | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 79e2bb8 | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 013fd4d | 24.14 KiB | 1.04 MiB | 1.02 MiB |
| 3b01aaf | 24.14 KiB | 1.06 MiB | 1.04 MiB |
| 2c4362a | 24.14 KiB | 1.07 MiB | 1.04 MiB |
| 5d67f5d | 24.14 KiB | 1.06 MiB | 1.04 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Convert SentryAutoBreadcrumbTrackingIntegration from Objective-C to Swift following the SwiftIntegration protocol pattern. Updated the conversion guide with learnings including:
💡 Motivation and Context
Closes #6860
💚 How did you test it?
#skip-changelog