-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(apple): Add docs for screenshot masking options #15658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM with a few suggestions.
docs/platforms/apple/common/enriching-events/screenshots/index.mdx
Outdated
Show resolved
Hide resolved
Bundle ReportChanges will increase total bundle size by 107.29kB (0.3%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
Co-authored-by: Philipp Hofmann <[email protected]>
|
BLOCKED BY getsentry/sentry-cocoa#6953 |
docs/platforms/apple/common/enriching-events/screenshots/index.mdx
Outdated
Show resolved
Hide resolved
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding.
….mdx Co-authored-by: Alex Krawiec <[email protected]>
|
As the implementation of a screenshot specific public API is taking longer than expected with getsentry/sentry-cocoa#6953 I'll merge this PR now as-is and iterate the documentation when the new public API is available. |
DESCRIBE YOUR PR
Adds documentation about configuring masking of screenshots. Based on the already existing session replay masking documentation. As the two options sets are different (
options.sessionReplay.*vsoptions.screenshot.*) we should duplicate the documentation for now in case of drift.We need to revisit this issue with getsentry/sentry-cocoa#6060
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: