Skip to content

Conversation

@tstollin
Copy link

@tstollin tstollin commented Jan 15, 2026

Fixes: #3918.

@tstollin tstollin marked this pull request as ready for review January 15, 2026 12:27
@tstollin
Copy link
Author

Tested with our company enterprise where we try to configure code security programmatically.

@gmlewis gmlewis changed the title feat: add support for delegated bypass in code security configuration… feat: Add support for delegated bypass in code security configuration… Jan 15, 2026
@gmlewis gmlewis changed the title feat: Add support for delegated bypass in code security configuration… feat: Add support for delegated bypass in code security org config Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.45%. Comparing base (5458fbc) to head (bfe41ab).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3920   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files         203      203           
  Lines       14954    14954           
=======================================
  Hits        13826    13826           
  Misses        926      926           
  Partials      202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tstollin.
Please unit tests (either new or update existing ones) that demonstrate the inclusion of the new fields.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 15, 2026
@tstollin tstollin force-pushed the csc-secrete-scanning-delegated-bypass branch from bfe41ab to 7c9b5c7 Compare January 16, 2026 06:07
@tstollin tstollin force-pushed the csc-secrete-scanning-delegated-bypass branch from 7c9b5c7 to 01125e4 Compare January 16, 2026 06:20
@tstollin
Copy link
Author

tstollin commented Jan 16, 2026

Thank you, @tstollin. Please unit tests (either new or update existing ones) that demonstrate the inclusion of the new fields.

Thanks for the feedback @gmlewis. I've added a new unit test and the security_configuration_id field to the BypassReviewer. The new field is automatically added by GitHub in responses.
Regarding the unit test I'm not sure whether this suffices. If it does not, I would be grateful for any advice.

@tstollin tstollin requested a review from gmlewis January 16, 2026 06:21
@tstollin
Copy link
Author

Unfortunately, I missed point 6. of "submitting a patch" in your https://github.com/google/go-github/blob/master/CONTRIBUTING.md and did force-pushes. :(
Is there any chance to salvage this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for Bypass privileges in Code Security Configurations

2 participants