ui: WIP support tab.selectionURI to override currentSelectionTab #4495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillobruni
commented
Jan 21, 2026
| } else { | ||
| const currentTabUri = this.tabs.currentTabUri; | ||
| const tab = this.tabs.resolveTab(currentTabUri); | ||
| if (tab && tab.content instanceof TraceTab) { |
Contributor
Author
There was a problem hiding this comment.
this needs some better cleaner approach for sure :) (double dispatch or a custom TraceTabManagger or so)
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21207093757-1-ui/ui/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First hacky approach to showcase how V8RuntimeCallStatsTab could hijack the current selection and stay focused.
Previously we'd always switch to the current_selection tab in
TraceImpl.onSelectionChangewhich breaks usability for custom tabs that render content based on the current selection.