ui: Add custom details panel for AndroidBinderViz slices #4582
+170
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a custom details panel `BinderSliceDetailsPanel` for the slices on the binder transactions breakdown tracks, with the following information: - transaction type: 'Client binder transaction' or 'Server binder reply' - interfaceName - methodName - a SliceRef link to the actual thread slice for easy navigation - Standard slice details via the existing `renderDetails()` method.
zezeozue
reviewed
Jan 26, 2026
zezeozue
reviewed
Jan 26, 2026
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21440918654-1-ui/ui/index.html |
zezeozue
approved these changes
Jan 26, 2026
stevegolton
requested changes
Jan 28, 2026
1. the loading of sliceDetails and binderTxnDetails is done in 'async load()' method of TrackEventDetailsPanel 2. if getSlice() or getBinderTxnDetails() fail, we let it crash as this is a developer issue 3. Used DetailsShell widget inside render() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a custom details panel
BinderSliceDetailsPanelfor the slices on the binder transactions breakdown tracks,
with the following information:
or 'Server binder reply'
renderDetails()method.