-
Notifications
You must be signed in to change notification settings - Fork 676
Add Megascale Perfetto plugin #4609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21451691784-1-ui/ui/index.html |
| addQueryResultsTab(trace, { | ||
| query: ` | ||
| SELECT | ||
| a.int_value AS network_latency_us, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive by: this and below can be simplified tremendously with some careful use of EXTRACT_ARG: https://perfetto.dev/docs/analysis/perfetto-sql-getting-started#helper-functions
|
|
||
| async onTraceLoad(trace: Trace): Promise<void> { | ||
| trace.onTraceReady.addListener(() => { | ||
| addQueryResultsTab(trace, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why btw this could not be done with a macro + a startup command - https://perfetto.dev/docs/visualization/ui-automation?
You can even land this stuff in Google3 instead of needing to have a plugin in our repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could work. I see that I can share macros internally in Google. Is it possible to also share them externally? I only see "Configure them in Settings > Macros and run them via the command palette" in the public documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're actively working on it - see #3227 and https://github.com/LalitMaganti/perfetto-test-extensions
This adds important statistics upon trace load. This plugin is disabled by default for now.