Skip to content

Conversation

@bbadawi1
Copy link

This adds important statistics upon trace load. This plugin is disabled by default for now.

@bbadawi1 bbadawi1 requested a review from stevegolton January 28, 2026 19:04
@github-actions
Copy link

🎨 Perfetto UI Build

✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21451691784-1-ui/ui/index.html

addQueryResultsTab(trace, {
query: `
SELECT
a.int_value AS network_latency_us,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive by: this and below can be simplified tremendously with some careful use of EXTRACT_ARG: https://perfetto.dev/docs/analysis/perfetto-sql-getting-started#helper-functions


async onTraceLoad(trace: Trace): Promise<void> {
trace.onTraceReady.addListener(() => {
addQueryResultsTab(trace, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why btw this could not be done with a macro + a startup command - https://perfetto.dev/docs/visualization/ui-automation?

You can even land this stuff in Google3 instead of needing to have a plugin in our repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could work. I see that I can share macros internally in Google. Is it possible to also share them externally? I only see "Configure them in Settings > Macros and run them via the command palette" in the public documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're actively working on it - see #3227 and https://github.com/LalitMaganti/perfetto-test-extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants