feat: Add registerFiles for you can use gcs files with mldev. #1970
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
copybara/852951219
branch
12 times, most recently
from
ff61922 to
de66808
Compare
How does this all work? - Web and node need to have __identical__ interfaces. - We overload the public registerFiles method in NodeFiles - The generator generates registerFilesInternal as private. the generator doesn't have a protected option. so we use an additional `protected async _registerFiles` wrapper so that registerFiles can call through to internalRegisterFiles. - The public RegisterFilesParameters type uses `any` for the type of auth, because web can't access the GoogleAuth types. - Renamed the old RegisterFilesParameters to InternalRegisterFilesParameters to abvoid conflict. this is backwards compatible - it wasn't publicly used. PiperOrigin-RevId: 852951219
copybara-service
bot
force-pushed
the
copybara/852951219
branch
from
de66808 to
bb174d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add registerFiles for you can use gcs files with mldev.
How does this all work?
protected async _registerFileswrapper so that registerFiles can call through to internalRegisterFiles.anyfor the type of auth, because web can't access the GoogleAuth types.