-
Notifications
You must be signed in to change notification settings - Fork 4k
Maybe use io.grpc.Uri for target parsing in ManagedChannelRegistry #12608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jdcormie
wants to merge
4
commits into
grpc:master
Choose a base branch
from
jdcormie:grpc-uri-9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Copyright 2026 The gRPC Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package io.grpc; | ||
|
|
||
| import com.google.common.annotations.VisibleForTesting; | ||
| import com.google.common.base.Strings; | ||
|
|
||
| /** Global variables that govern major changes to the behavior of more than one grpc module. */ | ||
| @Internal | ||
| public class InternalFeatureFlags { | ||
| private static boolean enableRfc3986Uris = getFlag("GRPC_ENABLE_RFC3986_URIS", false); | ||
|
|
||
| /** Whether to parse targets as RFC 3986 URIs (true), or use {@link java.net.URI} (false). */ | ||
| @VisibleForTesting | ||
| public static boolean setRfc3986UrisEnabled(boolean value) { | ||
| boolean prevValue = enableRfc3986Uris; | ||
| enableRfc3986Uris = value; | ||
| return prevValue; | ||
| } | ||
|
|
||
| /** Whether to parse targets as RFC 3986 URIs (true), or use {@link java.net.URI} (false). */ | ||
| public static boolean getRfc3986UrisEnabled() { | ||
| return enableRfc3986Uris; | ||
| } | ||
|
|
||
| public static boolean getFlag(String envVarName, boolean enableByDefault) { | ||
| String envVar = System.getenv(envVarName); | ||
| if (envVar == null) { | ||
| envVar = System.getProperty(envVarName); | ||
| } | ||
| if (envVar != null) { | ||
| envVar = envVar.trim(); | ||
| } | ||
| if (enableByDefault) { | ||
| return Strings.isNullOrEmpty(envVar) || Boolean.parseBoolean(envVar); | ||
| } else { | ||
| return !Strings.isNullOrEmpty(envVar) && Boolean.parseBoolean(envVar); | ||
| } | ||
| } | ||
|
|
||
| private InternalFeatureFlags() {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To visibility restrict inside Google, we split the modules into two java_libraries: the main code, the Internal* accessors. The Internal* accessors can reference the main code, but that means the other direction isn't possible. We need to put the flag in a non-Internal-prefixed class, then expose that outside the package via the Internal* class.