Create Table : sdg_target_indicator | Model | API | Test cases #596
+241
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyliu
requested changes
Jan 15, 2026
Member
fyliu
left a comment
fyliu
left a comment
There was a problem hiding this comment.
Looks good. Thanks!
This one is missing seed data. But it also looks like the seed data needs some preparation before we can import it. Most of the rows don't have sdg_id https://docs.google.com/spreadsheets/u/0/d/1x_zZ8JLS2hO-zG0jUocOJmX16jh-DF5dccrd_OEGNZ0/htmlview?pli=1#gid=16627220
github-project-automation
bot
moved this from 👀PR being reviewed
to PR changes requested
in P: PD: Project Board
Member
Author
|
@fyliu Should we merge this and create a separate issue for adding seed data, since that part needs review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No UI - Only Backend changes