update gRPC benchmarks to support real crypto#1123
Merged
SaidAltury-ibm merged 1 commit intohyperledger-labs:mainfrom Feb 4, 2026
Merged
update gRPC benchmarks to support real crypto#1123SaidAltury-ibm merged 1 commit intohyperledger-labs:mainfrom
SaidAltury-ibm merged 1 commit intohyperledger-labs:mainfrom
Conversation
mbrandenburger
requested changes
Feb 3, 2026
Member
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks @SaidAltury-ibm This is a good addition to the benchmark. I left a few comments for improvements. WDYT?
mbrandenburger
requested changes
Feb 3, 2026
Member
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
@SaidAltury-ibm Thanks for updating the PR.
mbrandenburger
approved these changes
Feb 4, 2026
Member
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks @SaidAltury-ibm LGTM; let's squash the commits and merge this one.
Signed-off-by: Said Altury <[email protected]>
SaidAltury-ibm
force-pushed
the
SA_benchmarks_grpc
branch
from
3c5355e to
91eb332
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation focuses on the Authentication and Message Integrity layer flow "real". By utilizing real X509 identities, we can measure the specific impact of signing and verifying request/response payloads, which is distinct from the downstream transaction endorsement logic. while keeping the "fake" flow available without the overhead.