Skip to content

Conversation

@scpike
Copy link
Contributor

@scpike scpike commented Nov 6, 2024

This removes use of the "anonymous block argument" feature which is only supported in Ruby 3.1+ so that the library stays backwards compatible to earlier ruby versions.

This removes use of the "anonymous block argument" feature which is
only supported in Ruby 3.1+ so that the library stays backwards
compatible to earlier ruby versions.
@deepakmahakale
Copy link

Can we get this pr merged. Current version breaks on ruby 2.7

@pacso
Copy link
Collaborator

pacso commented Jan 19, 2026

@seejohnrun - what are your thoughts on this? Do we want to actively support version of Ruby / Rails which are end-of-life? If we do, where do we draw the line?

@scpike
Copy link
Contributor Author

scpike commented Jan 20, 2026

@seejohnrun - what are your thoughts on this? Do we want to actively support version of Ruby / Rails which are end-of-life? If we do, where do we draw the line?

I made the PR because I think it's helpful when gems support the versions of rubies their gemspecs allow. If you want to drop Ruby 2.x support explicitly, it'd still be nice for the latest version of the gem before that one to include this patch.

@pacso
Copy link
Collaborator

pacso commented Jan 20, 2026

Yep - it's a fair comment.

I've updated the PR to pass against all of the versions back to Rails 6.1 and Ruby 2.6. I'll review it again in the morning when I'm not so tired and get it merged.

@pacso pacso merged commit 32ff145 into ice-cube-ruby:master Jan 20, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants