WEBDEV-8109 Expand status indicator capabilities #23
+355
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebecca-shoptaw
commented
Jan 16, 2026
| return ( | ||
| choose( | ||
| settings.inputType, | ||
| [['radio', () => this.radioPropInputTemplate(settings)]], |
Contributor
Author
There was a problem hiding this comment.
There's a lot of overlap between these templates, and I wonder if they could be tidied up a bit or the approach adjusted (something worth considering if we plan to eventually use this code in the story-template
rebecca-shoptaw
commented
Jan 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 60.00% 68.42% +8.42%
==========================================
Files 5 5
Lines 45 57 +12
Branches 5 7 +2
==========================================
+ Hits 27 39 +12
Misses 15 15
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to display a success or error icon to the status indicator, and the ability to hide the loading indicator dots, and begins encapsulating prop input rendering within the
ia-status-indicator-storycomponent.