fix: race condition during merging #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-held
commented
Jan 20, 2026
alexander-held
force-pushed
the
fix/merge-race-condition
branch
from
c9c60f6 to
3e38bdb
Compare
Member
Author
|
In its current state this may have helped partially but hit a new case I have previously not seen:
The more common version prior to the changes here was:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom processing caused
ReduceSchedulingErrorinstances which seemed to be more frequent with more complex workloads. Switch todask.distributed.as_completedinstead, which does not run into these issues based on my testing.