#2460: Fix getBoolean(GLExt.GL_FRAMEBUFFER_SRGB_CAPABLE_EXT) causes error 1280 (invalid enum) #2461
+3
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
GL_FRAMEBUFFER_SRGB_CAPABLE_EXT is actually queryable via glGetBooleanv, but it is provided by the EXT_framebuffer_sRGB extension. I suspect that some drivers that provided opengl3+ capabilities, do not implement a fallback for this extension. |
riccardobl
requested changes
Jan 14, 2026
Member
riccardobl
left a comment
riccardobl
left a comment
There was a problem hiding this comment.
Since this check is only used for debugging purposes and, as noted, it is not reliable across different platforms, i am ok with removing it.
But this PR needs to be cleaned from the unrelated formatting and logging changes, can you do that?
Thanks
jme3-core/src/main/java/com/jme3/renderer/opengl/GLRenderer.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Done |
riccardobl
added
the
defect
riccardobl
added a commit
to riccardobl/jmonkeyengine
that referenced
this pull request
Jan 24, 2026
commit b3c946c Author: Ryan McDonough <[email protected]> Date: Sun Jan 18 21:18:38 2026 -0500 Change int to long in LwjglPlatform.java commit d311b8d Author: Ryan McDonough <[email protected]> Date: Sun Jan 18 21:13:44 2026 -0500 Replace switch with if statements commit 4b30bee Author: Ryan McDonough <[email protected]> Date: Sun Jan 18 20:57:09 2026 -0500 Change int to long for LWJGL 3.4.0 compatibility commit 128d179 Author: Ryan McDonough <[email protected]> Date: Sun Jan 18 20:48:12 2026 -0500 Remove OpenVR References from BulletDebugAppState.java commit ba331a8 Author: Ryan McDonough <[email protected]> Date: Sun Jan 18 20:13:06 2026 -0500 Delete jme3-vr directory commit a0c5063 Author: Ryan McDonough <[email protected]> Date: Sun Jan 18 15:38:45 2026 -0500 Remove OpenVr commit b61d9e6 Author: Ryan McDonough <[email protected]> Date: Sun Jan 18 14:56:37 2026 -0500 LWJGL 3.4.0 and Remove OpenVR @stephengold notified me that LWJGL 3.4 has been released and has also done some testing in their non jME projects with this new version already. (big thanks for keeping a tab on this area) I still have most of my own jME projects running lwjgl2 ('ve been procrastinating upgrading to LWJGL3 for quite a while now, long overdue), so I will finally do so in my own projects so I can help test as well. OpenVR is also no longer supported in LWJGL 3.4.0 so it appears it needed removed, but (unless I'm mistaken) this should not be an issue since the Tamarin VR library is using the newer openXR, and openVR is considered outdated and deprecated. Any jME apps still relying on openVR can still use v3.9 or earlier without issue (@richardTingle correct me if I'm incorrect on any of this) commit 77fdf95 Author: Wyatt Gillette <[email protected]> Date: Sat Jan 17 11:22:46 2026 +0100 Remove GL_FRAMEBUFFER_SRGB_CAPABLE_EXT check to fix error 1280 (invalid enum) in some platforms (jMonkeyEngine#2461) commit 0a84a08 Author: Riccardo Balbo <[email protected]> Date: Sat Jan 17 11:21:04 2026 +0100 make tempvars closeable (jMonkeyEngine#2580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GL_FRAMEBUFFER_SRGB_CAPABLE_EXTis likely not a queryable state viaglGetBooleanv. It's a capability flag for configuring framebuffers, not for querying the global sRGB state. It's good that it's commented out.This PR should fix #1996