Fix obsolescence warnings about interface orientation on iOS #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
There was a problem hiding this comment.
Pull request overview
This PR updates the interface orientation detection logic for iOS to address obsolescence warnings. The code has been refactored to use EffectiveGeometry.InterfaceOrientation for newer iOS versions while maintaining backward compatibility.
Key Changes:
- Refactored version checking logic to extract
windowSceneonce before determining orientation - Added support for iOS 26+ using
EffectiveGeometry.InterfaceOrientation - Restructured code to eliminate duplication in orientation assignment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…#73) * Add null check for windowScene to prevent NullReferenceException * Use FirstOrDefault to prevent InvalidOperationException --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: janusw <[email protected]>
* by avoiding duplicate use of StatusBarOrientation
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
janusw
added a commit
that referenced
this pull request
Dec 30, 2025
* because the test app did not always react properly to orientation changes on iOS 26 (i.e. the camera preview did not rotate properly when changing from portrait to landscape orientation) * the obsolescence warning returns, but at least things work properly this way on iOS 26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.