Prevent playing lands on NDFC backs #14305
Open
+84
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matoro
force-pushed
the
ojertaq
branch
2 times, most recently
from
26801f2 to
e73c0af
Compare
Grath
approved these changes
Jan 24, 2026
Jmlundeen
approved these changes
Jan 24, 2026
Contributor
Jmlundeen
left a comment
Jmlundeen
left a comment
There was a problem hiding this comment.
This can work unless someone else sees some eye cases this might miss or a better spot to prevent the ability.
JayDi85
requested changes
Jan 24, 2026
|
|
||
| // lands on the back of transforming double-faced cards should not be playable | ||
| if (this instanceof TransformingDoubleFacedCardHalf && ((DoubleFacedCardHalf)this).isBackSide()) { | ||
| all.removeIf(ability -> ability instanceof PlayLandAbility); |
Member
There was a problem hiding this comment.
CardImpl looks a bad place for fix, it's about TDFC, not global cards. See isIgnoreDefaultAbility and DoubleFacedCard. It already has tools to ignore land abilities. So something broken it on TDFC rework? Need research.
@Jmlundeen also lands problems must be added to TDFC issue tracker in #14099
| public void testModalAllowed() { | ||
| addCard(Zone.HAND, playerA, "Sink into Stupor"); | ||
| checkPlayableAbility("Should be able to play land", 1, PhaseStep.PRECOMBAT_MAIN, playerA, "Play Soporific Springs", true); | ||
| execute(); |
Member
There was a problem hiding this comment.
Must use good tests style with setStrictMode and setStopAt like
setStrictChooseMode(true);
setStopAt(1, PhaseStep.END_TURN);
execute();
It should not be possible to play a land on the back of a nonmodal (transforming) double-faced card from anywhere.
Contributor
Author
|
I redid this in the specific location as requested. I special-cased this in the verifier since it is now visible to it. Let me know if that is too specific. |
Grath
approved these changes
Jan 25, 2026
Jmlundeen
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not be possible to play a land on the back of a nonmodal (transforming) double-faced card from anywhere.