Align a pair of tokens with naming convention called out in tests #14317
+17
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenohedron
approved these changes
Jan 26, 2026
Contributor
xenohedron
left a comment
xenohedron
left a comment
There was a problem hiding this comment.
Looks like a fine cleanup to me
muz
force-pushed
the
token_naming_convention_a
branch
from
2106f72 to
6d1cbd5
Compare
Contributor
Author
|
Rebased given the other much larger tokens-database refactor just landed in master first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (currently ignored)
test_checkMissingTokenDatatest case has a schwack of warnings like below:There was an intention somewhere that tokens following a naming convention. This is likely one of those things that unless someone actually sits down to deal with it, it'll be a code smell that lurks for longer than it needs to.
In the interests of cleaning this up and making the test output cleaner as well as any other future token work, I can have a stab at cleaning these up as proposed below. If this change is welcome, I'm willing to go and clean up others to, to get this done hopefully once-and-for-all.
Just anecdotally, getting involved in contributing to this codebase is complex as is due to the age and size of it. Something that actively hindered me was inconsistencies where it wasn't immediately clear what was desired. So this hopefully leaves things in a better state than I found them, and makes it easier for the next person - albeit marginally.
Opting to just do two to illustrate the point and garner feedback, but also to make reviews manageable instead of dumping it all in one massive PR 😅