Skip to content

Require numpy 2.1 or newer in tests. Adopt SPEC-0 in the package. #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dstansby merged 6 commits into from
Jan 8, 2026
Merged

Require numpy 2.1 or newer in tests. Adopt SPEC-0 in the package. #321

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad01d2a
Switch `reshape` to `shape` and drop support for old numpy versions.
samcunliffe Jan 6, 2026
a0cb021
Fix tox.ini missing env from envlist.
samcunliffe Jan 6, 2026
65ed7d4
Remove pre-commit.ci badge since we're not using it anymore.
samcunliffe Jan 6, 2026
094250e
Was actually added in numpy 2.1. So we also don't support numpy 2.0.
samcunliffe Jan 6, 2026
d9226c4
Aaaand, we can remove a deprecation warning suppression.
samcunliffe Jan 6, 2026
40d360b
Full SPEC-0
samcunliffe Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ repos:
- id: trailing-whitespace

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.13.1
rev: v0.14.10
hooks:
- id: ruff-format

Expand All @@ -17,14 +17,14 @@ repos:
- id: napari-plugin-checks

- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.18.2
rev: v1.19.1
hooks:
- id: mypy
additional_dependencies: [numpy, matplotlib]
- id: mypy
additional_dependencies: [numpy>=2.1, matplotlib]

- repo: https://github.com/astral-sh/ruff-pre-commit
# Ruff version.
rev: 'v0.13.1'
rev: "v0.14.10"
hooks:
- id: ruff

Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
[![Python Version](https://img.shields.io/pypi/pyversions/napari-matplotlib.svg?color=green)](https://python.org)
[![tests](https://github.com/matplotlib/napari-matplotlib/workflows/tests/badge.svg)](https://github.com/matplotlib/napari-matplotlib/actions)
[![codecov](https://codecov.io/gh/matplotlib/napari-matplotlib/branch/main/graph/badge.svg)](https://codecov.io/gh/matplotlib/napari-matplotlib)
[![pre-commit.ci status](https://results.pre-commit.ci/badge/github/matplotlib/pytest-mpl/master.svg)](https://results.pre-commit.ci/latest/github/matplotlib/pytest-mpl/master)
[![napari hub](https://img.shields.io/endpoint?url=https://api.napari-hub.org/shields/napari-matplotlib)](https://napari-hub.org/plugins/napari-matplotlib)

A plugin to create Matplotlib plots from napari layers
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ packages = find:
install_requires =
matplotlib
napari>=0.5
numpy>=1.23
numpy>=2.1
tinycss2
python_requires = >=3.11
include_package_data = True
Expand Down
2 changes: 1 addition & 1 deletion src/napari_matplotlib/tests/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def fig_to_array(fig: Figure) -> npt.NDArray[np.uint8]:
io_buf.seek(0)
img_arr: npt.NDArray[np.uint8] = np.reshape(
np.frombuffer(io_buf.getvalue(), dtype=np.uint8),
newshape=(int(fig.bbox.bounds[3]), int(fig.bbox.bounds[2]), -1),
shape=(int(fig.bbox.bounds[3]), int(fig.bbox.bounds[2]), -1),
)
return img_arr

Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py{310,311,312}
envlist = py{311,312,313}
isolated_build = true

[gh-actions]
Expand Down