-
Notifications
You must be signed in to change notification settings - Fork 3
Copy for LLM on release notes in Dev Portal giving error #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy for LLM on release notes in Dev Portal giving error #1540
Conversation
Summary of ChangesHello @mm-jpoole, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the "Copy for LLM" functionality on the Dev Portal was failing specifically for release notes. The changes ensure that release note content is correctly processed for Large Language Models by explicitly enabling markdown output for these pages and standardizing their URL configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix an issue with the 'Copy for LLM' functionality on release notes pages by enabling markdown output for them. This is achieved by adding _index.md files with a cascade configuration and updating the frontmatter of all individual release note files. The changes look correct to solve the issue.
I have two main suggestions to improve maintainability and consistency:
-
Remove Redundancy: The new
_index.mdfiles ingeoip/release-notesandminfraud/release-notesuse Hugo'scascadefeature to set theoutputsfor all pages in those sections. This makes theoutputskey in each individual release note file redundant. I've suggested removing it to centralize the configuration, which makes future changes easier. -
Improve Consistency: The
geoiprelease notes are being updated to use a new URL structure (/release-notes/{year}/) via theurlandaliasesfrontmatter keys. However, theminfraudrelease notes are not. For better site-wide consistency, I've suggested applying the same URL restructuring to theminfraudrelease notes.
These suggestions are detailed in the specific comments on the files.
52323a6 to
196cb0b
Compare
Deploying dev-site with
|
| Latest commit: |
47fd639
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://850f3179.dev-site-4ua.pages.dev |
| Branch Preview URL: | https://jpoole-sco-8371-copy-for-llm.dev-site-4ua.pages.dev |
tsc was compiling as CommonJS, causing an error. Now it compiles as a module.
196cb0b to
47fd639
Compare
|
First commit was cherry-picked from #1541 because it is not yet merged at commit time and is required for the |
https://linear.app/maxmind/issue/SCO-8371/copy-for-llm-on-release-notes-in-dev-portal-giving-error
The Copy for LLM functionality appears to be working for all dev site pages except the release notes where there is an error.
https://dev.maxmind.com/minfraud/release-notes/2025/
https://dev.maxmind.com/geoip/release-notes/2026/
GeoIP was recently updated to 2026 but minFraud was not, though it could still be related…
Thank you!