Skip to content

Conversation

@horgh
Copy link
Contributor

@horgh horgh commented Jan 19, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @horgh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the release workflow by integrating an automatic update of the Gemfile.lock file. By running bundle install as part of the release script, it guarantees that the project's dependency lock file accurately reflects the newly released version, thereby maintaining consistency and preventing potential dependency-related issues in subsequent builds or deployments.

Highlights

  • Release Script Enhancement: The dev-bin/release.sh script has been updated to include a bundle install command. This ensures that the Gemfile.lock file is automatically updated to reflect the new version of the gem after the lib/minfraud/version.rb file is modified during the release process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds bundle install to the release script. This is a good change as it ensures the Gemfile.lock is updated to reflect the new version number during the release process. I have one suggestion to improve the script's robustness by adding a check to ensure the bundle command is available before it's used.

Comment on lines +87 to +89
# Update version in Gemfile.lock.
bundle install

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For robustness, it's good practice to verify that a command exists before attempting to execute it. The script already does this for other commands like perl and rake in its pre-flight checks. A similar check should be added for bundle to ensure the script fails early with a clear error message if it's not installed.

While it would be ideal to add this check with the others at the top of the script, placing it here is a valuable improvement.

Suggested change
# Update version in Gemfile.lock.
bundle install
# Update version in Gemfile.lock.
check_command bundle
bundle install

@horgh horgh force-pushed the wstorey/release-script branch from caa069e to 151f567 Compare January 19, 2026 17:27
horgh and others added 3 commits January 19, 2026 09:27
This ensures CI fails immediately with a clear error if Gemfile.lock
is out of sync, rather than silently updating it.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
This fixes JRuby CI builds which were failing with BUNDLE_FROZEN=true
because the lockfile lacked JRuby-compatible gem variants.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants