Fix domain override validation to accept valid URLs with protocols

[Copilot]

Fix domain override validation to accept valid URLs

• Understand the current implementation and test cases
• Update get_validated_domain_override() to validate URLs instead of rejecting them
• Update URL construction logic to handle both domain-only and full URL overrides
• Fix URL construction for domain with port format (example.com:8080)
• Update/fix existing tests to match new validation behavior
• Add new tests for valid URL formats (http://, https://, domain with port)
• Run tests to validate the changes (30 tests passing)
• Run linter to ensure code quality
• Request code review and address feedback with clarifying comments
• Fix lint errors (trailing whitespace removed)
• Add validation for malformed URLs (http:8080)
• Update comment clarity for domain with optional port
• All changes complete and ready for merge

Summary

Fixed the validation logic in get_validated_domain_override() to accept valid URLs with protocols (http://, https://) instead of rejecting them. The parameter represents an endpoint with protocol, not just a domain name.

Code Review Feedback Addressed

1. ✅ Trailing whitespace - Auto-formatted with ruff
2. ✅ Malformed URL validation - Added check for "http:8080" style malformed URLs
3. ✅ Comment clarity - Updated to specify "domain with optional port"
4. ℹ️ URL construction duplication - Kept for defense-in-depth as endpoint can come from different sources (override or discovery service)

Supported Formats

✅ Valid (Accepted):

• example.com → prepends https://
• example.com:8080 → prepends https://
• http://localhost:8080 → used as-is
• https://example.com → used as-is

❌ Invalid (Rejected):

• ftp://example.com → invalid protocol
• example.com/path → domain with path
• https:// → protocol without hostname
• http:8080 → malformed URL (missing slashes)

Original prompt

The logic within get_validated_domain_override from file microsoft_agents_a365/observability/core/exporters/utils.py‎ is off. The problem is that even do the parameter is named domain, this actually does not represent a domain but a endpoint with protocol.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR fixes the validation logic for the A365_OBSERVABILITY_DOMAIN_OVERRIDE environment variable to accept URLs with protocols (http/https) in addition to domain-only formats. Previously, the validation incorrectly rejected all URLs containing "://", even though the parameter represents a complete endpoint URL rather than just a domain name.

Changes:

• Updated validation in utils.py to accept both full URLs (with http/https protocols) and domain-only formats (with optional ports)
• Modified URL construction in agent365_exporter.py to handle both full URLs and domain-only values correctly
• Added comprehensive unit and integration tests covering various URL format edge cases

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/utils.py	Updated get_validated_domain_override() to accept http/https URLs while rejecting invalid protocols and malformed URLs; added urlparse import
libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter.py	Modified URL construction logic to use full URLs as-is when protocol present, or prepend https:// for domain-only formats; added urlparse import
tests/observability/core/exporters/test_utils.py	Added 11 unit tests covering validation edge cases including various URL formats, protocols, and invalid inputs
tests/observability/core/test_agent365_exporter.py	Added 3 integration tests for URL override scenarios with https, http, and domain:port formats; updated existing test to use invalid protocol (ftp)

[nikhilNava]

@copilot - fic the lint error run below and fix errors
uv run --frozen ruff format --check .

[Copilot]

@copilot - fic the lint error run below and fix errors
uv run --frozen ruff format --check .

Fixed in commit 91dad5c - ran ruff format to fix all formatting issues. All files now pass ruff format --check . with 143 files formatted correctly.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• astral.sh
  • Triggering command: /usr/bin/curl curl -LsSf REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)