-
Notifications
You must be signed in to change notification settings - Fork 15
engineering: Refactor HttpFile into standalone file #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the HttpFile struct and its implementation from the file_reader.rs file into a new standalone http_file.rs file, improving code organization and maintainability.
Key changes:
- Extracted
HttpFilestruct and all related implementations to a newhttp_file.rsfile - Updated module structure to expose the new
http_filemodule - Cleaned up imports in
file_reader.rsand added imports to the new file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/trident/src/io_utils/mod.rs | Added http_file module declaration |
| crates/trident/src/io_utils/http_file.rs | New file containing the complete HttpFile implementation extracted from file_reader.rs, including all methods, trait implementations, and tests |
| crates/trident/src/io_utils/file_reader.rs | Removed HttpFile implementation, added import for HttpFile from the new module, and cleaned up related imports |
|
/AzurePipelines run [GITHUB]-trident-pr-e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
🔍 Description
Minor refactor to separate a large file into two.