feat(editor): add option to insert newline when folding last line #286834
+446
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new editor option foldingAddNewlineAtEnd that controls whether a newline is automatically inserted when folding the last line of a file. The feature defaults to enabled (true) to maintain clean file separation when the last line is folded.
Changes:
- Added
foldingAddNewlineAtEndboolean option to editor configuration (defaults to true) - Modified folding model to check this option and conditionally insert newline when folding last line
- Updated all test files to pass editor instance to FoldingModel constructor
- Added comprehensive test coverage for the new feature
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/editor/common/config/editorOptions.ts | Added foldingAddNewlineAtEnd option definition and registration |
| src/vs/editor/common/standalone/standaloneEnums.ts | Updated EditorOption enum to include new option with renumbered subsequent entries |
| src/vs/editor/contrib/folding/browser/foldingModel.ts | Implemented newline insertion logic in toggleCollapseState method, added editor parameter to constructor |
| src/vs/editor/contrib/folding/browser/folding.ts | Updated FoldingModel instantiation to pass editor instance |
| src/vs/editor/contrib/folding/test/browser/foldingModel.test.ts | Added helper function and four new tests for the feature, updated all existing test instantiations |
| src/vs/editor/contrib/folding/test/browser/hiddenRangeModel.test.ts | Added helper function and updated test instantiation to pass editor mock |
src/vs/editor/contrib/folding/test/browser/foldingModel.test.ts
Outdated
Show resolved
Hide resolved
src/vs/editor/contrib/folding/test/browser/hiddenRangeModel.test.ts
Outdated
Show resolved
Hide resolved
akyTheDev
force-pushed
the
akyTheDev/add-new-line-at-end-on-fold
branch
2 times, most recently
from
bc03435 to
2077e3d
Compare
Introduce a new editor option `foldingAddNewlineAtEnd` that controls whether a newline character is added when folding the last line of a file. This option defaults to true, ensuring that a newline is inserted to maintain a clean separation at the end of the file when the last line is folded. The implementation includes updates to the folding model to check for this option and conditionally insert a newline. Additionally, tests have been added to verify the behavior of this new feature under various scenarios, including when the option is disabled or when the last line is already empty.
akyTheDev
force-pushed
the
akyTheDev/add-new-line-at-end-on-fold
branch
from
2077e3d to
62f7c3d
Compare
Contributor
|
should send screenshot/screen recording |
Author
|
Here is the screen recording 🙂 output.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new editor option
foldingAddNewlineAtEndthat controls whether a newline character is added when folding the last line of a file. This option defaults to true, ensuring that a newline is inserted to maintain a clean separation at the end of the file when the last line is folded.The implementation includes updates to the folding model to check for this option and conditionally insert a newline. Additionally, tests have been added to verify the behavior of this new feature under various scenarios, including when the option is disabled or when the last line is already empty.
#279302