Editor GPU: Fix wrapped line indent #286934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where wrapped lines were not properly indented in the GPU-accelerated editor rendering. The fix ensures that when rendering wrapped lines, the horizontal offset accounts for the visual indent (faux indent) that should precede the content on continuation lines.
Changes:
- Initialize
absoluteOffsetXto account for the faux indent by calculating(lineData.minColumn - 1) * charWidthinstead of starting at 0
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/editor/browser/gpu/renderStrategy/viewportRenderStrategy.ts | Fixed wrapped line indent calculation in viewport render strategy |
| src/vs/editor/browser/gpu/renderStrategy/fullFileRenderStrategy.ts | Fixed wrapped line indent calculation in full file render strategy |
dmitrivMS
approved these changes
Jan 10, 2026
github-project-automation
bot
moved this from In Review
to Done
in VS Code Editor GPU Renderer
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
Editor GPU: Fix wrapped line indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238404