Add DistributedCacheEventStreamStore
#1136
Conversation
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.AI.Abstractions" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" /> | ||
| <PackageReference Include="Microsoft.Extensions.Caching.Abstractions" /> |
There was a problem hiding this comment.
Is ModelContextProtocol.Core the right assembly for this, or should it instead live in ModelContextProtocol or ModelContextProtocol.AspNetCore?
| streamId = string.Empty; | ||
| sequence = 0; | ||
|
|
||
| var parts = eventId.Split(Separator); |
There was a problem hiding this comment.
On Core you could use the span-based Split, which would avoid the string[] and also avoid needing to materialize strings for parts[0]/[1]/[2].
| // Base64-encode session and stream IDs so the event ID can be parsed | ||
| // even if the original IDs contain the ':' separator character | ||
| var sessionBase64 = Convert.ToBase64String(Encoding.UTF8.GetBytes(sessionId)); | ||
| var streamBase64 = Convert.ToBase64String(Encoding.UTF8.GetBytes(streamId)); |
There was a problem hiding this comment.
Separate from this PR, we should really add Base64 overloads that handle this without the intermediate byte[]. I will follow up.
| /// </summary> | ||
| internal static class CacheKeys | ||
| { | ||
| private const string Prefix = "mcp:sse:"; |
There was a problem hiding this comment.
If we wanted to ship a new version that breaks the caching format and thus should ignore existing entries, how would we version it? change this prefix to include a version number?
Opening initially as a draft until #1077 gets merged