CSHARP-5805: Add support for server selection's deprioritized servers to all topologies #1862
+3,992
−1,663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends server selection's deprioritized servers feature from Sharded clusters to all topology types (Single, ReplicaSet, LoadBalanced). The changes replace the legacy PriorityServerSelector with a new DeprioritizedServersServerSelector that wraps any server selector and filters out deprioritized servers, falling back to including them if no other servers are available.
Changes:
- Introduced
DeprioritizedServersServerSelectorto replacePriorityServerSelectorwith a wrapper pattern - Deprecated
PriorityServerSelectorfor future removal - Added comprehensive test specifications covering deprioritized servers across all topology types
Reviewed changes
Copilot reviewed 132 out of 132 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/MongoDB.Driver/Core/Clusters/ServerSelectors/DeprioritizedServersServerSelector.cs | New selector implementing the wrapper pattern for deprioritized servers |
| src/MongoDB.Driver/Core/Clusters/ServerSelectors/PriorityServerSelector.cs | Marked as obsolete with deprecation notice |
| src/MongoDB.Driver/Core/Clusters/IClusterExtensions.cs | Updated to use new DeprioritizedServersServerSelector instead of composite pattern |
| src/MongoDB.Driver/Core/Bindings/WritableServerBinding.cs | Updated to use new DeprioritizedServersServerSelector instead of composite pattern |
| tests/MongoDB.Driver.Tests/Core/Clusters/ServerSelectors/DeprioritizedServersServerSelectorTests.cs | New comprehensive test suite for the selector |
| tests/MongoDB.Driver.Tests/Core/Clusters/ServerSelectors/PriorityServerSelectorTests.cs | Removed obsolete tests |
| tests/MongoDB.Driver.Tests/Core/Clusters/ClusterTests.cs | Removed sharded-only tests for deprioritized servers |
| tests/MongoDB.Driver.Tests/Specifications/server-selection/ServerSelectionTestRunner.cs | Added support for deprioritized_servers field in test definitions |
| specifications/server-selection/tests/server_selection//Deprioritized.{yml,json} | New test specifications for deprioritized servers across all topologies |
| specifications/server-selection/tests/server_selection//.{yml,json} | Formatting updates to existing test files |
| specifications/server-selection/tests/README.rst | Removed obsolete documentation file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… to all topologies
sanych-sun
force-pushed
the
csharp5805
branch
from
7de3ad3 to
2e2af0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.