Skip to content

fix: add error logging to empty catch block in keymap.ts (@Dawn-Fighter) #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dawn-Fighter wants to merge 2 commits into from
Closed

fix: add error logging to empty catch block in keymap.ts (@Dawn-Fighter) #7344

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf42a7
fix: add error logging to empty catch block in keymap.ts
Jan 11, 2026
6c1e9dd
Merge branch 'master' into fix/keymap-empty-catch-block
fehmer Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion frontend/src/ts/elements/keymap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,11 @@ async function flashKey(key: string, correct?: boolean): Promise<void> {
duration: 250,
easing: "out(5)",
});
} catch (e) {}
} catch (e) {
if (e instanceof Error) {
console.log("could not flash keymap key: " + e.message);
}
}
});
}

Expand Down
Loading