[context-menu] Right click on menu item closes context menu on Windows #3612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
type: bug
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
@atomiks can you provide some reproduction for what the failing test is doing? See https://app.circleci.com/pipelines/github/mui/base-ui/18503/workflows/13724f2e-ee8b-435d-94da-e7b422ebdde0/jobs/194806 I am asking because on MacOS, the mouse up does not even fire, while on Windows the context menu opens on mouse up, so I don't understand when will this code run. I can't reproduce #3224 on this PR or master, so I am not sure what should the test capture. |
Contributor
|
@mnajdova it's for right-click down -> drag -> right-click up (release), which macOS's native context menu supports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3595
The issue is that https://github.com/mui/base-ui/blob/master/packages/react/src/menu/item/useMenuItem.ts#L75 fires on Windows, but not on MacOS. Apperantly on MacOS the operating system intercepts the event to show the context menu.
I added a check at the beginning of the handler to ignore the code if it comes from right-click, this way we can have coherent behavior between Windows and other OSs.
There is another difference that I noticed between Windows and MacOS, on Windows the context menu opens on mouse up, while on MacOs it opens on mouse down.