another fix for C2999 error #105
Merged
+23
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `error C2999: maximum template instantiation depth of 1000 exceeded (see '/templateDepth:N')` was persistent 2. ``` error C2039: 'Generate': is not a member of 'NativeGenerator<0>' error C3861: 'Generate': identifier not found ```
Collaborator
|
I initially started review from format issues (extra new line at the end of the file for no reason), but actually it has critical issues with the code itself: by specializing NativeGenerator<0> with an empty Generate() method, recursion chain will be immediately stopped on its very first iteration and thus won't work at all. Please test before pushing. |
Collaborator
|
Ok I finally had to install VS 2026 myself to also confirm that your current code compiled with no such errors and made some corrections to your latest variant. I'll merge this now, but apply those corrections in the further commits if you don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error C2999: maximum template instantiation depth of 1000 exceeded (see '/templateDepth:N')was persistent (commit 64d1f0e didn't work