Skip to content

chore: add critical error metric for numaplane analysis template #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vigith merged 6 commits into from
Jan 29, 2026
Merged

chore: add critical error metric for numaplane analysis template #3154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b1d3b1
add critical error metric for numaplane analysis template
adarsh0728 Jan 23, 2026
460bcc6
fix lint
adarsh0728 Jan 23, 2026
2413fc6
Merge branch 'main' into critical-metric
vaibhavtiwari33 Jan 23, 2026
c4a8e42
Fix missing imports after conflict resolution
vaibhavtiwari33 Jan 23, 2026
a00f768
resolve conflicts and add replica filter in pending metric
adarsh0728 Jan 28, 2026
291c17f
fix lint and codegen
adarsh0728 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 22 additions & 21 deletions config/advanced-install/namespaced-numaflow-server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,30 +152,31 @@ data:
\ display_name: Vertex Pending Messages\n metric_description: This gauge
metric keeps track of the total number of messages that are waiting to be processed
over varying time frames of 1min, 5min, 15min and default period of 2min. \n required_filters:\n
\ - namespace\n - pipeline\n - vertex\n dimensions:\n
\ - namespace\n - pipeline\n - vertex\n # replica is
added so that the pending calculation is done only for 0th replica.\n -
replica\n dimensions:\n - name: pod\n # expr: optional expression
for prometheus query\n # overrides the default expression\n filters:\n
\ - name: pod\n required: false\n - name: period\n
\ required: false\n - name: vertex\n # expr: optional
expression for prometheus query\n # overrides the default expression\n
\ filters:\n - name: period\n required: false\n\n-
name: mono_vertex_gauge\n objects: \n - mono-vertex\n title: MonoVertex Gauge
Metrics\n description: This pattern represents the gauge metrics for a mono-vertex
across different dimensions\n expr: |\n sum($metric_name{$filters}) by ($dimension,
period)\n params:\n - name: start_time\n required: false\n - name:
end_time\n required: false\n metrics:\n - metric_name: monovtx_pending\n
\ display_name: MonoVertex Pending Messages\n metric_description: This
gauge metric keeps track of the total number of messages that are waiting to be
processed over varying time frames of 1min, 5min, 15min and default period of
2min. \n required_filters:\n - namespace\n - mvtx_name\n dimensions:\n
\ - name: pod\n # expr: optional expression for prometheus query\n
\ # overrides the default expression\n filters:\n -
name: pod\n required: false\n - name: period\n required:
false\n - name: vertex\n # expr: optional expression for prometheus
query\n # overrides the default expression\n filters:\n -
name: period\n required: false\n\n- name: mono_vertex_gauge\n objects:
\n - mono-vertex\n title: MonoVertex Gauge Metrics\n description: This pattern
represents the gauge metrics for a mono-vertex across different dimensions\n expr:
|\n sum($metric_name{$filters}) by ($dimension, period)\n params:\n - name:
start_time\n required: false\n - name: end_time\n required: false\n
\ metrics:\n - metric_name: monovtx_pending\n display_name: MonoVertex
Pending Messages\n metric_description: This gauge metric keeps track of the
total number of messages that are waiting to be processed over varying time frames
of 1min, 5min, 15min and default period of 2min. \n required_filters:\n -
namespace\n - mvtx_name\n dimensions:\n - name: pod\n #
expr: optional expression for prometheus query\n # overrides the default
expression\n filters:\n - name: pod\n required:
false\n - name: period\n required: false\n - name:
mono-vertex\n # expr: optional expression for prometheus query\n #
overrides the default expression\n filters:\n - name: period\n
\ required: false\n\n- name: mono_vertex_histogram\n objects: \n
\ - mono-vertex\n title: MonoVertex Histogram Metrics\n description: This
pattern is for P99, P95, P90 and P50 quantiles for a mono-vertex across different
false\n - name: mono-vertex\n # expr: optional expression for
prometheus query\n # overrides the default expression\n filters:\n
\ - name: period\n required: false\n\n- name: mono_vertex_histogram\n
\ objects: \n - mono-vertex\n title: MonoVertex Histogram Metrics\n description:
This pattern is for P99, P95, P90 and P50 quantiles for a mono-vertex across different
dimensions\n expr: |\n histogram_quantile($quantile, sum by($dimension,le)
(rate($metric_name{$filters}[$duration])))\n params:\n - name: quantile\n
\ required: true\n - name: duration\n required: true\n - name:
Expand Down
43 changes: 22 additions & 21 deletions config/advanced-install/numaflow-server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,30 +159,31 @@ data:
\ display_name: Vertex Pending Messages\n metric_description: This gauge
metric keeps track of the total number of messages that are waiting to be processed
over varying time frames of 1min, 5min, 15min and default period of 2min. \n required_filters:\n
\ - namespace\n - pipeline\n - vertex\n dimensions:\n
\ - namespace\n - pipeline\n - vertex\n # replica is
added so that the pending calculation is done only for 0th replica.\n -
replica\n dimensions:\n - name: pod\n # expr: optional expression
for prometheus query\n # overrides the default expression\n filters:\n
\ - name: pod\n required: false\n - name: period\n
\ required: false\n - name: vertex\n # expr: optional
expression for prometheus query\n # overrides the default expression\n
\ filters:\n - name: period\n required: false\n\n-
name: mono_vertex_gauge\n objects: \n - mono-vertex\n title: MonoVertex Gauge
Metrics\n description: This pattern represents the gauge metrics for a mono-vertex
across different dimensions\n expr: |\n sum($metric_name{$filters}) by ($dimension,
period)\n params:\n - name: start_time\n required: false\n - name:
end_time\n required: false\n metrics:\n - metric_name: monovtx_pending\n
\ display_name: MonoVertex Pending Messages\n metric_description: This
gauge metric keeps track of the total number of messages that are waiting to be
processed over varying time frames of 1min, 5min, 15min and default period of
2min. \n required_filters:\n - namespace\n - mvtx_name\n dimensions:\n
\ - name: pod\n # expr: optional expression for prometheus query\n
\ # overrides the default expression\n filters:\n -
name: pod\n required: false\n - name: period\n required:
false\n - name: vertex\n # expr: optional expression for prometheus
query\n # overrides the default expression\n filters:\n -
name: period\n required: false\n\n- name: mono_vertex_gauge\n objects:
\n - mono-vertex\n title: MonoVertex Gauge Metrics\n description: This pattern
represents the gauge metrics for a mono-vertex across different dimensions\n expr:
|\n sum($metric_name{$filters}) by ($dimension, period)\n params:\n - name:
start_time\n required: false\n - name: end_time\n required: false\n
\ metrics:\n - metric_name: monovtx_pending\n display_name: MonoVertex
Pending Messages\n metric_description: This gauge metric keeps track of the
total number of messages that are waiting to be processed over varying time frames
of 1min, 5min, 15min and default period of 2min. \n required_filters:\n -
namespace\n - mvtx_name\n dimensions:\n - name: pod\n #
expr: optional expression for prometheus query\n # overrides the default
expression\n filters:\n - name: pod\n required:
false\n - name: period\n required: false\n - name:
mono-vertex\n # expr: optional expression for prometheus query\n #
overrides the default expression\n filters:\n - name: period\n
\ required: false\n\n- name: mono_vertex_histogram\n objects: \n
\ - mono-vertex\n title: MonoVertex Histogram Metrics\n description: This
pattern is for P99, P95, P90 and P50 quantiles for a mono-vertex across different
false\n - name: mono-vertex\n # expr: optional expression for
prometheus query\n # overrides the default expression\n filters:\n
\ - name: period\n required: false\n\n- name: mono_vertex_histogram\n
\ objects: \n - mono-vertex\n title: MonoVertex Histogram Metrics\n description:
This pattern is for P99, P95, P90 and P50 quantiles for a mono-vertex across different
dimensions\n expr: |\n histogram_quantile($quantile, sum by($dimension,le)
(rate($metric_name{$filters}[$duration])))\n params:\n - name: quantile\n
\ required: true\n - name: duration\n required: true\n - name:
Expand Down
2 changes: 2 additions & 0 deletions config/base/numaflow-server/numaflow-server-metrics-proxy-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ data:
- namespace
- pipeline
- vertex
# replica is added so that the pending calculation is done only for 0th replica.
- replica
dimensions:
- name: pod
# expr: optional expression for prometheus query
Expand Down
43 changes: 22 additions & 21 deletions config/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46439,30 +46439,31 @@ data:
\ display_name: Vertex Pending Messages\n metric_description: This gauge
metric keeps track of the total number of messages that are waiting to be processed
over varying time frames of 1min, 5min, 15min and default period of 2min. \n required_filters:\n
\ - namespace\n - pipeline\n - vertex\n dimensions:\n
\ - namespace\n - pipeline\n - vertex\n # replica is
added so that the pending calculation is done only for 0th replica.\n -
replica\n dimensions:\n - name: pod\n # expr: optional expression
for prometheus query\n # overrides the default expression\n filters:\n
\ - name: pod\n required: false\n - name: period\n
\ required: false\n - name: vertex\n # expr: optional
expression for prometheus query\n # overrides the default expression\n
\ filters:\n - name: period\n required: false\n\n-
name: mono_vertex_gauge\n objects: \n - mono-vertex\n title: MonoVertex Gauge
Metrics\n description: This pattern represents the gauge metrics for a mono-vertex
across different dimensions\n expr: |\n sum($metric_name{$filters}) by ($dimension,
period)\n params:\n - name: start_time\n required: false\n - name:
end_time\n required: false\n metrics:\n - metric_name: monovtx_pending\n
\ display_name: MonoVertex Pending Messages\n metric_description: This
gauge metric keeps track of the total number of messages that are waiting to be
processed over varying time frames of 1min, 5min, 15min and default period of
2min. \n required_filters:\n - namespace\n - mvtx_name\n dimensions:\n
\ - name: pod\n # expr: optional expression for prometheus query\n
\ # overrides the default expression\n filters:\n -
name: pod\n required: false\n - name: period\n required:
false\n - name: vertex\n # expr: optional expression for prometheus
query\n # overrides the default expression\n filters:\n -
name: period\n required: false\n\n- name: mono_vertex_gauge\n objects:
\n - mono-vertex\n title: MonoVertex Gauge Metrics\n description: This pattern
represents the gauge metrics for a mono-vertex across different dimensions\n expr:
|\n sum($metric_name{$filters}) by ($dimension, period)\n params:\n - name:
start_time\n required: false\n - name: end_time\n required: false\n
\ metrics:\n - metric_name: monovtx_pending\n display_name: MonoVertex
Pending Messages\n metric_description: This gauge metric keeps track of the
total number of messages that are waiting to be processed over varying time frames
of 1min, 5min, 15min and default period of 2min. \n required_filters:\n -
namespace\n - mvtx_name\n dimensions:\n - name: pod\n #
expr: optional expression for prometheus query\n # overrides the default
expression\n filters:\n - name: pod\n required:
false\n - name: period\n required: false\n - name:
mono-vertex\n # expr: optional expression for prometheus query\n #
overrides the default expression\n filters:\n - name: period\n
\ required: false\n\n- name: mono_vertex_histogram\n objects: \n
\ - mono-vertex\n title: MonoVertex Histogram Metrics\n description: This
pattern is for P99, P95, P90 and P50 quantiles for a mono-vertex across different
false\n - name: mono-vertex\n # expr: optional expression for
prometheus query\n # overrides the default expression\n filters:\n
\ - name: period\n required: false\n\n- name: mono_vertex_histogram\n
\ objects: \n - mono-vertex\n title: MonoVertex Histogram Metrics\n description:
This pattern is for P99, P95, P90 and P50 quantiles for a mono-vertex across different
dimensions\n expr: |\n histogram_quantile($quantile, sum by($dimension,le)
(rate($metric_name{$filters}[$duration])))\n params:\n - name: quantile\n
\ required: true\n - name: duration\n required: true\n - name:
Expand Down
43 changes: 22 additions & 21 deletions config/namespace-install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46318,30 +46318,31 @@ data:
\ display_name: Vertex Pending Messages\n metric_description: This gauge
metric keeps track of the total number of messages that are waiting to be processed
over varying time frames of 1min, 5min, 15min and default period of 2min. \n required_filters:\n
\ - namespace\n - pipeline\n - vertex\n dimensions:\n
\ - namespace\n - pipeline\n - vertex\n # replica is
added so that the pending calculation is done only for 0th replica.\n -
replica\n dimensions:\n - name: pod\n # expr: optional expression
for prometheus query\n # overrides the default expression\n filters:\n
\ - name: pod\n required: false\n - name: period\n
\ required: false\n - name: vertex\n # expr: optional
expression for prometheus query\n # overrides the default expression\n
\ filters:\n - name: period\n required: false\n\n-
name: mono_vertex_gauge\n objects: \n - mono-vertex\n title: MonoVertex Gauge
Metrics\n description: This pattern represents the gauge metrics for a mono-vertex
across different dimensions\n expr: |\n sum($metric_name{$filters}) by ($dimension,
period)\n params:\n - name: start_time\n required: false\n - name:
end_time\n required: false\n metrics:\n - metric_name: monovtx_pending\n
\ display_name: MonoVertex Pending Messages\n metric_description: This
gauge metric keeps track of the total number of messages that are waiting to be
processed over varying time frames of 1min, 5min, 15min and default period of
2min. \n required_filters:\n - namespace\n - mvtx_name\n dimensions:\n
\ - name: pod\n # expr: optional expression for prometheus query\n
\ # overrides the default expression\n filters:\n -
name: pod\n required: false\n - name: period\n required:
false\n - name: vertex\n # expr: optional expression for prometheus
query\n # overrides the default expression\n filters:\n -
name: period\n required: false\n\n- name: mono_vertex_gauge\n objects:
\n - mono-vertex\n title: MonoVertex Gauge Metrics\n description: This pattern
represents the gauge metrics for a mono-vertex across different dimensions\n expr:
|\n sum($metric_name{$filters}) by ($dimension, period)\n params:\n - name:
start_time\n required: false\n - name: end_time\n required: false\n
\ metrics:\n - metric_name: monovtx_pending\n display_name: MonoVertex
Pending Messages\n metric_description: This gauge metric keeps track of the
total number of messages that are waiting to be processed over varying time frames
of 1min, 5min, 15min and default period of 2min. \n required_filters:\n -
namespace\n - mvtx_name\n dimensions:\n - name: pod\n #
expr: optional expression for prometheus query\n # overrides the default
expression\n filters:\n - name: pod\n required:
false\n - name: period\n required: false\n - name:
mono-vertex\n # expr: optional expression for prometheus query\n #
overrides the default expression\n filters:\n - name: period\n
\ required: false\n\n- name: mono_vertex_histogram\n objects: \n
\ - mono-vertex\n title: MonoVertex Histogram Metrics\n description: This
pattern is for P99, P95, P90 and P50 quantiles for a mono-vertex across different
false\n - name: mono-vertex\n # expr: optional expression for
prometheus query\n # overrides the default expression\n filters:\n
\ - name: period\n required: false\n\n- name: mono_vertex_histogram\n
\ objects: \n - mono-vertex\n title: MonoVertex Histogram Metrics\n description:
This pattern is for P99, P95, P90 and P50 quantiles for a mono-vertex across different
dimensions\n expr: |\n histogram_quantile($quantile, sum by($dimension,le)
(rate($metric_name{$filters}[$duration])))\n params:\n - name: quantile\n
\ required: true\n - name: duration\n required: true\n - name:
Expand Down
Loading