-
Notifications
You must be signed in to change notification settings - Fork 4
Add GHA workflow for building MLIR Python bindings #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Can you add a |
|
Also, add test using this: https://github.com/sklam/mlir-python-bindings-feedstock/blob/numbacc_mlir20/recipe/test.py |
| c_compiler: # [osx] | ||
| - clang_bootstrap # [osx] | ||
| cxx_compiler: # [osx] | ||
| - clang_bootstrap # [osx] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should match llvmdev: https://github.com/numba/llvmlite/blob/main/conda-recipes/llvmdev/conda_build_config.yaml
| - numba::llvmdev {{ version }} # [build_platform != target_platform] | ||
| - cross-python_{{ target_platform }} # [build_platform != target_platform] | ||
| - python # [build_platform != target_platform] | ||
| - numpy # [build_platform != target_platform] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this, it doesn't need numpy when I test build this. https://github.com/sklam/mlir-python-bindings-feedstock/blob/89b079091ddb1e6ac500afd08443f7cab869894d/recipe/meta.yaml#L30
| - zlib | ||
| - zstd # [win] | ||
| - python | ||
| - numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this, it doesn't need numpy when I test build this.
| run: | ||
| - python | ||
| - pyyaml | ||
| - mlir {{ version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should not depends on mlir.
As titled