Skip to content

Conversation

@rrahir
Copy link
Collaborator

@rrahir rrahir commented Jan 22, 2026

Some formulas, like ROW & COLUMN need to know the coordinates of the cell on which they are applied to be computed and we did not provide those in the evaluation context when evaluating isolated formulas.

How to reproduce:

  • in a spreadsheet, go to the last row
  • in a cell of the last row, write the formula =MUNIT(ROW()) -> the formula is in #SPILL error because we did not extend the size of the spreadsheet

This also cause issues in standalone composers in which the hovered result displays an error.

How to reproduce:

  • in a standalone composer, write =ROW()
  • hover the ROW function -> it displays #ERROR

Task: 5798610

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jan 22, 2026

Pull request status dashboard

Some formulas, like ROW & COLUMN need to know the coordinates of the
cell on which they are applied to be computed and we did not provide
those in the evaluation context when evaluating isolated formulas.

How to reproduce:

- in a spreadsheet, go to the last row
- in a cell of the last row, write the formula `=MUNIT(ROW())`
-> the formula is in #SPILL error because we did not extend the size of
the spreadsheet

This also cause issues in standalone composers in which the hovered
result displays an error.

How to reproduce:

- in a standalone composer, write =ROW()
- hover the ROW function
-> it displays #ERROR

Task: 5798610
@rrahir rrahir force-pushed the saas-18.3-fix-row-eval-in-composer-rar branch from 2d4716f to a47dd5e Compare January 23, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants