[IMP] runbot: improve error merge #1182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Do
force-pushed
the
18.0-better-error-merge-xdo
branch
from
6eccfe7 to
cc52145
Compare
Xavier-Do
force-pushed
the
18.0-better-error-merge-xdo
branch
2 times, most recently
from
31e5a4b to
6539992
Compare
d-fence
requested changes
Dec 22, 2025
runbot/models/build_error.py
Outdated
| for field in fields_to_merge + fields_to_copy: | ||
| if previous_error[field]: | ||
| if field in fields_to_merge and error[field] and error[field] != previous_error[field] and not self.env.su: | ||
| raise UserError(f"error {error.id} as already a responsible ({error.responsible}) cannot assign {previous_error.responsible}") |
Contributor
There was a problem hiding this comment.
Adapt the UserError in accordance of the field that is causing the error.
Xavier-Do
force-pushed
the
18.0-better-error-merge-xdo
branch
from
6539992 to
43745a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.