Skip to content

Conversation

@AgnieszkaZaba
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.77%. Comparing base (c30b62d) to head (06e22a1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1782   +/-   ##
=======================================
  Coverage   86.76%   86.77%           
=======================================
  Files         414      414           
  Lines       10485    10500   +15     
=======================================
+ Hits         9097     9111   +14     
- Misses       1388     1389    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AgnieszkaZaba AgnieszkaZaba changed the title Trivia: isotopic methods for molar and isotopic mixing ratio and molecular isotope ratio Trivia: methods for molar and isotopic mixing ratio and molecular isotope ratio Jan 8, 2026
@AgnieszkaZaba AgnieszkaZaba requested a review from slayoo January 8, 2026 12:56
@AgnieszkaZaba AgnieszkaZaba changed the title Trivia: methods for molar and isotopic mixing ratio and molecular isotope ratio Trivia: methods for molar and isotopic mixing ratio and molecular isotope ratio; new formula for Mv Jan 13, 2026
@AgnieszkaZaba
Copy link
Collaborator Author

Due to changes in Mv formula, eps constant is changed (https://github.com/open-atmos/PySDM/pull/1782/changes#diff-a92c92afb234b4c133efa00e86436fc4ba428e59cfa9ae1f7ce8d861e53e0951L807)
It might be connected to this issue #1207.
Hence, the error in Rozanski & Sonntag example(https://github.com/open-atmos/PySDM/actions/runs/20957304845/job/60251181084?pr=1782#step:4:692).

With new formula Mv is slightly smaller (Mv_new - Mv_old = -2.2829816474778664e-09).

@AgnieszkaZaba AgnieszkaZaba changed the title Trivia: methods for molar and isotopic mixing ratio and molecular isotope ratio; new formula for Mv Trivia: methods for molar and isotopic mixing ratio and molecular isotope ratio; new test for Mv Jan 16, 2026
@slayoo slayoo added this pull request to the merge queue Jan 16, 2026
Merged via the queue into open-atmos:main with commit 5f5051c Jan 16, 2026
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants